From 06f0453ad27c92633d3630dbe49a16dcb0281d04 Mon Sep 17 00:00:00 2001 From: Julien Lepiller Date: Tue, 17 Mar 2020 00:05:32 +0100 Subject: guix: import: opam: Use a default repository. * guix/import/opam.scm (opam->guix-package): Use a default value for `repository`. --- guix/import/opam.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'guix') diff --git a/guix/import/opam.scm b/guix/import/opam.scm index 394415fdd4..ae7df8a8b5 100644 --- a/guix/import/opam.scm +++ b/guix/import/opam.scm @@ -250,7 +250,7 @@ path to the repository." (substring version 1) version))))) -(define* (opam->guix-package name #:key repository) +(define* (opam->guix-package name #:key (repository (get-opam-repository))) "Import OPAM package NAME from REPOSITORY (a directory name) or, if REPOSITORY is #f, from the official OPAM repository. Return a 'package' sexp or #f on failure." -- cgit v1.2.3 From 8d003ca34499705d8dbccfcae4b7dd9bfe30c93c Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Tue, 17 Mar 2020 16:51:14 +0100 Subject: build-system: linux-module: Break some long lines. * gnu/build/linux-modules.scm (make-linux-module-builder, lower): Break some long commentary lines. --- guix/build-system/linux-module.scm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) (limited to 'guix') diff --git a/guix/build-system/linux-module.scm b/guix/build-system/linux-module.scm index ba76ab85c3..1e1a07d0a2 100644 --- a/guix/build-system/linux-module.scm +++ b/guix/build-system/linux-module.scm @@ -78,7 +78,8 @@ (lambda* (#:key inputs outputs #:allow-other-keys) (let* ((out (assoc-ref outputs "out")) (out-lib-build (string-append out "/lib/modules/build"))) - ; TODO: Only preserve the minimum, i.e. [Kbuild], Kconfig, scripts, include, ".config". + ;; TODO: Only preserve the minimum, i.e. [Kbuild], Kconfig, + ;; scripts, include, ".config". (copy-recursively "." out-lib-build) (let* ((linux (assoc-ref inputs "linux"))) (install-file (string-append linux "/System.map") @@ -111,7 +112,11 @@ ("linux-module-builder" ,(make-linux-module-builder linux)) ,@native-inputs - ;; TODO: Remove "gmp", "mpfr", "mpc" since they are only needed to compile the gcc plugins. Maybe remove "flex", "bison", "elfutils", "perl", "openssl". That leaves very little ("bc", "gcc", "kmod"). + ;; TODO: Remove "gmp", "mpfr", "mpc" since they are + ;; only needed to compile the gcc plugins. Maybe + ;; remove "flex", "bison", "elfutils", "perl", + ;; "openssl". That leaves very little ("bc", "gcc", + ;; "kmod"). ,@(package-native-inputs linux))) (outputs outputs) (build linux-module-build) -- cgit v1.2.3 From 771c5e155d7862ed91a5d503eecc00c1db1150ad Mon Sep 17 00:00:00 2001 From: Florian Pelz Date: Thu, 12 Mar 2020 11:08:16 +0100 Subject: store: Fix many guix commands failing on some locales. Partly fixes . At least 'guix environment', 'guix install' and 'guix pull' on 'az_AZ.utf8' and 'tr_TR.utf8' were affected. * guix/store.scm (store-path-hash-part): Move base path detection to ... (store-path-base): ... this new exported procedure. (store-path-package-name): Use it instead of locale-dependent regexps. (store-regexp*): Remove. --- guix/store.scm | 32 +++++++++++++++----------------- 1 file changed, 15 insertions(+), 17 deletions(-) (limited to 'guix') diff --git a/guix/store.scm b/guix/store.scm index 5768a2ba7a..2c3675dca6 100644 --- a/guix/store.scm +++ b/guix/store.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017, 2018, 2019 Ludovic Courtès ;;; Copyright © 2018 Jan Nieuwenhuizen ;;; Copyright © 2019, 2020 Mathieu Othacehe +;;; Copyright © 2020 Florian Pelz ;;; ;;; This file is part of GNU Guix. ;;; @@ -43,7 +44,6 @@ #:use-module (srfi srfi-35) #:use-module (srfi srfi-39) #:use-module (ice-9 match) - #:use-module (ice-9 regex) #:use-module (ice-9 vlist) #:use-module (ice-9 popen) #:use-module (ice-9 threads) @@ -173,6 +173,7 @@ store-path? direct-store-path? derivation-path? + store-path-base store-path-package-name store-path-hash-part direct-store-path @@ -1949,29 +1950,26 @@ valid inputs." "Return #t if PATH is a derivation path." (and (store-path? path) (string-suffix? ".drv" path))) -(define store-regexp* - ;; The substituter makes repeated calls to 'store-path-hash-part', hence - ;; this optimization. - (mlambda (store) - "Return a regexp matching a file in STORE." - (make-regexp (string-append "^" (regexp-quote store) - "/([0-9a-df-np-sv-z]{32})-([^/]+)$")))) +(define (store-path-base path) + "Return the base path of a path in the store." + (and (string-prefix? (%store-prefix) path) + (let ((base (string-drop path (+ 1 (string-length (%store-prefix)))))) + (and (> (string-length base) 33) + (not (string-index base #\/)) + base)))) (define (store-path-package-name path) "Return the package name part of PATH, a file name in the store." - (let ((path-rx (store-regexp* (%store-prefix)))) - (and=> (regexp-exec path-rx path) - (cut match:substring <> 2)))) + (let ((base (store-path-base path))) + (string-drop base (+ 32 1)))) ;32 hash part + 1 hyphen (define (store-path-hash-part path) "Return the hash part of PATH as a base32 string, or #f if PATH is not a syntactically valid store path." - (and (string-prefix? (%store-prefix) path) - (let ((base (string-drop path (+ 1 (string-length (%store-prefix)))))) - (and (> (string-length base) 33) - (let ((hash (string-take base 32))) - (and (string-every %nix-base32-charset hash) - hash)))))) + (let* ((base (store-path-base path)) + (hash (string-take base 32))) + (and (string-every %nix-base32-charset hash) + hash))) (define (derivation-log-file drv) "Return the build log file for DRV, a derivation file name, or #f if it -- cgit v1.2.3