From 665467767577172db40eea510583dbf2faf56a58 Mon Sep 17 00:00:00 2001 From: Ludovic Courtès Date: Wed, 6 Nov 2019 22:02:34 +0100 Subject: derivations: Use a regular hash table for the module cache. The hit rate of the 'add-data-to-store' cache goes from 10% to 4% on: guix build -e '(@@ (gnu packages libreoffice) libreoffice)' -nd * guix/derivations.scm (%module-cache): Turn into a regular hash table. It didn't make sense to use a weak-value hash table given that values are pairs. --- guix/derivations.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'guix/derivations.scm') diff --git a/guix/derivations.scm b/guix/derivations.scm index bde937044a..6cdf55b1fe 100644 --- a/guix/derivations.scm +++ b/guix/derivations.scm @@ -1208,7 +1208,7 @@ they can refer to each other." (define %module-cache ;; Map a list of modules to its 'imported+compiled-modules' result. - (make-weak-value-hash-table)) + (make-hash-table)) (define* (imported+compiled-modules store modules #:key (system (%current-system)) -- cgit v1.2.3