From e2f47efee62010f6382fa5a4c43c6eb1b3c3d365 Mon Sep 17 00:00:00 2001 From: Ricardo Wurmus Date: Wed, 23 Jan 2019 22:06:02 +0100 Subject: gnu: catimg: Simplify. * gnu/packages/image-viewers.scm (catimg)[arguments]: Rename custom "configure" phase to "patch-convert"; remove custom "build" phase; move "install-script" phase after "install"; simplify phases. --- gnu/packages/image-viewers.scm | 39 +++++++++++++-------------------------- 1 file changed, 13 insertions(+), 26 deletions(-) (limited to 'gnu/packages/image-viewers.scm') diff --git a/gnu/packages/image-viewers.scm b/gnu/packages/image-viewers.scm index 4188ff2f15..895802cc94 100644 --- a/gnu/packages/image-viewers.scm +++ b/gnu/packages/image-viewers.scm @@ -301,37 +301,24 @@ your images. Among its features are: `(#:tests? #f ; no tests #:phases (modify-phases %standard-phases - (replace 'configure - (lambda* (#:key inputs #:allow-other-keys) - (let* ((magic (assoc-ref %build-inputs "imagemagick")) - (convert (string-append magic "/bin/convert"))) - (substitute* "catimg" - ;; By replacing "convert", we also replace the "convert" - ;; in the message 'The version of convert is too old, don't - ;; expect good results :('. This should not happen, but in - ;; practice this error message should not affect us. - (("convert") convert)) - #t))) - (replace 'build + (add-after 'unpack 'patch-convert (lambda _ - (let* ((out (assoc-ref %outputs "out")) - (man (string-append out "/share/man/man1"))) - (zero? (system* "cmake" - (string-append "-DCMAKE_INSTALL_PREFIX=" out) - (string-append "-DMAN_OUTPUT_PATH=" man) - ".")) - (zero? (system* "make"))))) - (add-before 'install 'install-script + (substitute* "catimg" + ;; By replacing "convert", we also replace the "convert" + ;; in the message 'The version of convert is too old, don't + ;; expect good results :('. This should not happen, but in + ;; practice this error message should not affect us. + (("convert") (which "convert"))) + #t)) + (add-after 'install 'install-script (lambda* (#:key outputs #:allow-other-keys) ;; The bash script lacks an file extension. We have to rename ;; it so that the C program and the bash script can be happy ;; side by side. - (let* ((out (assoc-ref outputs "out")) - (bin (string-append out "/bin"))) - (install-file "catimg" bin) - (rename-file (string-append bin "/catimg") - (string-append bin "/catimg.sh")) - #t)))))) + (copy-file "../source/catimg" + (string-append (assoc-ref outputs "out") + "/bin/catimg.sh")) + #t))))) (inputs `(("imagemagick" ,imagemagick))) ; for the bash script version (home-page "https://github.com/posva/catimg") -- cgit v1.2.3