From 1391dcb054f42e9ca58496db3269bee6e05f9653 Mon Sep 17 00:00:00 2001 From: Ludovic Courtès Date: Mon, 13 Oct 2014 22:33:31 +0200 Subject: derivations: Memoize 'derivation-path->base16-hash'. This reduces run time of (package-derivation s emacs) by ~10%. * guix/derivations.scm (derivation-path->base16-hash): New procedure. (derivation-hash): Use it. --- guix/derivations.scm | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/guix/derivations.scm b/guix/derivations.scm index 7e974bf541..210afd2ed1 100644 --- a/guix/derivations.scm +++ b/guix/derivations.scm @@ -489,6 +489,16 @@ in SIZE bytes." (logxor o (bytevector-u8-ref bv i))) (loop (+ 1 i)))))) +(define derivation-path->base16-hash + (memoize + (lambda (file) + "Return a string containing the base16 representation of the hash of the +derivation at FILE." + (call-with-input-file file + (compose bytevector->base16-string + derivation-hash + read-derivation))))) + (define derivation-hash ; `hashDerivationModulo' in derivations.cc (memoize (lambda (drv) @@ -512,10 +522,7 @@ in SIZE bytes." ;; derivation. (let* ((inputs (map (match-lambda (($ path sub-drvs) - (let ((hash (call-with-input-file path - (compose bytevector->base16-string - derivation-hash - read-derivation)))) + (let ((hash (derivation-path->base16-hash path))) (make-derivation-input hash sub-drvs)))) inputs)) (drv (make-derivation outputs inputs sources -- cgit v1.2.3