summaryrefslogtreecommitdiff
path: root/guix/build/python-build-system.scm
diff options
context:
space:
mode:
authorMaxim Cournoyer <maxim.cournoyer@gmail.com>2020-10-19 17:14:04 -0400
committerMaxim Cournoyer <maxim.cournoyer@gmail.com>2020-10-20 21:11:12 -0400
commitdd4a4603bec437bd055ec42ed99afd122864eed0 (patch)
tree57817539de29b3306af5b04b61f13a07b929fe8f /guix/build/python-build-system.scm
parent82d1e90aaa08cbced55dd787355a2538f00b1628 (diff)
downloadguix-patches-dd4a4603bec437bd055ec42ed99afd122864eed0.tar
guix-patches-dd4a4603bec437bd055ec42ed99afd122864eed0.tar.gz
build-system/python: Revert changing of phase order.
Commit c94a2864d4 moved the 'check' phase back into its original place before the 'install' phase, but such a change would require adapting the definition of many Python packages which have come to rely on such phase ordering. * guix/build/python-build-system.scm (%standard-phases): Move the check phase back after the install phase, and update comment.
Diffstat (limited to 'guix/build/python-build-system.scm')
-rw-r--r--guix/build/python-build-system.scm6
1 files changed, 4 insertions, 2 deletions
diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
index a790c49494..4a07496d22 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -265,7 +265,8 @@ installed with setuptools."
(define %standard-phases
;; The build phase only builds C extensions and copies the Python sources,
;; while the install phase copies then byte-compiles the sources to the
- ;; prefix directory.
+ ;; prefix directory. The check phase is moved after the installation phase
+ ;; to ease testing the built package.
(modify-phases gnu:%standard-phases
(add-after 'unpack 'ensure-no-mtimes-pre-1980 ensure-no-mtimes-pre-1980)
(add-after 'ensure-no-mtimes-pre-1980 'enable-bytecode-determinism
@@ -273,8 +274,9 @@ installed with setuptools."
(delete 'bootstrap)
(delete 'configure) ;not needed
(replace 'build build)
- (replace 'check check)
+ (delete 'check) ;moved after the install phase
(replace 'install install)
+ (add-after 'install 'check check)
(add-after 'install 'wrap wrap)
(add-before 'strip 'rename-pth-file rename-pth-file)))